Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a browser compatibility issue where bookmark last visit times were incorrectly calculated on Chrome due to different sorting behaviors between Chrome and Firefox in the chrome.history.getVisits API.
- Adds a new
getMostRecentItemfunction that handles both Chrome's chronological and Firefox's reverse chronological ordering - Updates the HistoryManager to use this function instead of assuming the first item is the most recent
- Enhances test factories and test coverage to verify both browser ordering conventions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/treetop/HistoryManager.ts | Implements the core fix with getMostRecentItem function and updates all visit time calculations |
| test/utils/factories.ts | Adds createVisitItems factory to generate test data with different browser ordering conventions |
| src/treetop/HistoryManager.test.ts | Expands test coverage to verify both Chrome and Firefox ordering behaviors |
| CHANGELOG.md | Documents the bug fix in the changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The `chrome.history.getVisits` API behaves differently on different browsers: Firefox sorts the visits in reverse chronological order and Chrome sorts the visits in chronological order. Update the HistoryManager to handle both cases. This fixes a bug on Chrome where a previously visited bookmark might not display in a larger font even if it's been visited recently.
msmolens
force-pushed
the
fix-chrome-last-visit-time
branch
from
c31a787 to
538b3e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
chrome.history.getVisitsAPI behaves differently on different browsers: Firefox sorts the visits in reverse chronological order and Chrome sorts the visits in chronological order.Update the HistoryManager to handle both cases. This fixes a bug on Chrome where a previously visited bookmark might not display in a larger font even if it's been visited recently.
See: